Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make heartbeatPeriod const into a flag #356

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Make heartbeatPeriod const into a flag #356

merged 1 commit into from
Sep 26, 2019
+16 −10

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Sep 23, 2019

This is an important parameter when it comes to kubernetes scalability (it controlls the node/status patch QPS) and it deserves to be a flag instead of a constant.

/sig scalability

@k8s-ci-robot
Copy link
Contributor

Welcome @mm4tt!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 23, 2019

/assign @wangzhen127

@wangzhen127
Copy link
Member

/assign @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
wangzhen127
wangzhen127 reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@wangzhen127 wangzhen127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to use a different default value on GKE?

pkg/exporters/k8sexporter/condition/manager.go Outdated Show resolved Hide resolved
@mm4tt mm4tt force-pushed the heartbeat-period-flag branch from 9fc651f to 9b2e42e Compare September 25, 2019 12:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 25, 2019

/test pull-npd-e2e-node

wangzhen127
wangzhen127 reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@wangzhen127 wangzhen127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just a nit.

/cc @xueweiz

cmd/options/options.go Outdated
@@ -83,6 +83,9 @@ type NodeProblemDetectorOptions struct {

// NodeName is the node name used to communicate with Kubernetes ApiServer.
NodeName string

// K8sExporterHeartbeatPeriod is the period at which the k8s exporter does forcibly sync with apiserver.
K8sExporterHeartbeatPeriod time.Duration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: put this along with the k8s exporter ones above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@mm4tt mm4tt force-pushed the heartbeat-period-flag branch from 9b2e42e to 2e9da85 Compare September 26, 2019 07:59
@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wangzhen127, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 76865bd into kubernetes:master Sep 26, 2019
@wangzhen127 wangzhen127 mentioned this pull request Oct 9, 2019
Merged
@xueweiz xueweiz mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzhen127 wangzhen127 wangzhen127 left review comments

@andyxning andyxning Awaiting requested review from andyxning

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@xueweiz xueweiz Awaiting requested review from xueweiz

Assignees

@wangzhen127 wangzhen127

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mm4tt @k8s-ci-robot @wangzhen127 @wojtek-t